[webkit-reviews] review granted: [Bug 191585] [GTK][MiniBrowser] Handle Device Info permission requests : [Attachment 356004] Patch

[bugzilla-daemon at webkit.org]

Carlos Garcia Campos <cgarcia at igalia.com> has granted Thibault Saunier
<tsaunier at gnome.org>'s request for review:
Bug 191585: [GTK][MiniBrowser] Handle Device Info permission requests
https://bugs.webkit.org/show_bug.cgi?id=191585

Attachment 356004: Patch

https://bugs.webkit.org/attachment.cgi?id=356004&action=review




--- Comment #33 from Carlos Garcia Campos <cgarcia at igalia.com> ---
Comment on attachment 356004
  --> https://bugs.webkit.org/attachment.cgi?id=356004
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=356004&action=review

> Tools/MiniBrowser/gtk/BrowserTab.c:91
> +    gchar *origin_str = webkit_security_origin_to_string(origin);

origin_str -> originStr

> Tools/MiniBrowser/gtk/BrowserTab.c:257
> +	   if (g_hash_table_contains(userMediaPermissionGrantedOrigins,
webkit_web_view_get_uri(webView))) {

You should get the origin here too, not the URI.