[webkit-reviews] review granted: [Bug 192206] Inform clients when editable image attachment backing data changes : [Attachment 356102] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Nov 29 18:24:58 PST 2018
Wenson Hsieh <wenson_hsieh at apple.com> has granted Tim Horton
<thorton at apple.com>'s request for review:
Bug 192206: Inform clients when editable image attachment backing data changes
https://bugs.webkit.org/show_bug.cgi?id=192206
Attachment 356102: Patch
https://bugs.webkit.org/attachment.cgi?id=356102&action=review
--- Comment #4 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 356102
--> https://bugs.webkit.org/attachment.cgi?id=356102
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=356102&action=review
> Source/WebKit/UIProcess/API/Cocoa/APIAttachmentCocoa.mm:67
> + m_webPage->didInvalidateDataForAttachment(*this);
Should we also notify the delegate when Attachment::setFileWrapperGenerator
invalidates the file wrapper?
More information about the webkit-reviews
mailing list