[webkit-reviews] review granted: [Bug 192172] Make drawing tools available when an editable image is focused : [Attachment 356064] Patch

[bugzilla-daemon at webkit.org]

Dean Jackson <dino at apple.com> has granted Tim Horton <thorton at apple.com>'s
request for review:
Bug 192172: Make drawing tools available when an editable image is focused
https://bugs.webkit.org/show_bug.cgi?id=192172

Attachment 356064: Patch

https://bugs.webkit.org/attachment.cgi?id=356064&action=review




--- Comment #12 from Dean Jackson <dino at apple.com> ---
Comment on attachment 356064
  --> https://bugs.webkit.org/attachment.cgi?id=356064
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=356064&action=review

> Source/WebCore/editing/InsertEditableImageCommand.cpp:55
> +    m_imageElement->setAttributeWithoutSynchronization(styleAttr,
AtomicString("display: block", AtomicString::ConstructFromLiteral));

Should this be block? Image attachments in Mail are inline.

> Source/WebKit/UIProcess/ios/WKInkPickerControl.mm:83
> +    CGSize keyboardSize = [UIKeyboard
defaultSizeForInterfaceOrientation:[UIApp interfaceOrientation]];
> +    return [_inlinePicker sizeThatFits:keyboardSize];

Does this try to make the ink picker the same size as what a keyboard would be?
I thought it was less tall?

> Source/WebKit/UIProcess/ios/WKInkPickerControl.mm:94
> +    CGSize keyboardSize = [UIKeyboard
defaultSizeForInterfaceOrientation:[UIApp interfaceOrientation]];

You probably should use the size parameter here rather than ask for it again :)