[webkit-reviews] review granted: [Bug 192182] [MediaStream] DeviceIdHashSaltStorage should use iframe and top level documents : [Attachment 356061] Patch

[bugzilla-daemon at webkit.org]

youenn fablet <youennf at gmail.com> has granted Eric Carlson
<eric.carlson at apple.com>'s request for review:
Bug 192182: [MediaStream] DeviceIdHashSaltStorage should use iframe and top
level documents
https://bugs.webkit.org/show_bug.cgi?id=192182

Attachment 356061: Patch

https://bugs.webkit.org/attachment.cgi?id=356061&action=review




--- Comment #3 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 356061
  --> https://bugs.webkit.org/attachment.cgi?id=356061
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=356061&action=review

> Source/WebKit/UIProcess/DeviceIdHashSaltStorage.cpp:83
>  void DeviceIdHashSaltStorage::deleteDeviceIdHashSaltForOrigins(const
Vector<SecurityOriginData>& origins, CompletionHandler<void()>&&
completionHandler)

We probably need to update getDeviceIdHashSaltOrigins to also add the topOrigin
to origins.

> Source/WebKit/UIProcess/DeviceIdHashSaltStorage.h:50
> +	       : documentOrigin(documentOrigin)

WTFMove(documentOrigin) and WTFMove(parentOrigin)