[webkit-reviews] review granted: [Bug 192183] [ContentObservation] Make WKSetObservedContentChange logic more explicit : [Attachment 356062] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted zalan
<zalan at apple.com>'s request for review:
Bug 192183: [ContentObservation] Make WKSetObservedContentChange logic more
explicit
https://bugs.webkit.org/show_bug.cgi?id=192183

Attachment 356062: Patch

https://bugs.webkit.org/attachment.cgi?id=356062&action=review




--- Comment #2 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 356062
  --> https://bugs.webkit.org/attachment.cgi?id=356062
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=356062&action=review

> Source/WebCore/platform/ios/wak/WKContentObservation.cpp:82
> +    if (_WKContentChange == WKContentVisibilityChange)

Would be nice if the enum were ordered so you could do a > check here.