[webkit-reviews] review granted: [Bug 192174] Web Inspector: Uncaught Exception opening Web Inspector to Debugger Tab : [Attachment 356041] [PATCH] Proposed Fix

[bugzilla-daemon at webkit.org]

Devin Rousso <drousso at apple.com> has granted Joseph Pecoraro
<joepeck at webkit.org>'s request for review:
Bug 192174: Web Inspector: Uncaught Exception opening Web Inspector to Debugger
Tab
https://bugs.webkit.org/show_bug.cgi?id=192174

Attachment 356041: [PATCH] Proposed Fix

https://bugs.webkit.org/attachment.cgi?id=356041&action=review




--- Comment #2 from Devin Rousso <drousso at apple.com> ---
Comment on attachment 356041
  --> https://bugs.webkit.org/attachment.cgi?id=356041
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=356041&action=review

r=me

> Source/WebInspectorUI/UserInterface/Protocol/Connection.js:82
> +	       this._deferredScripts.push(callback);

NIT: Shouldn't this also be called `_deferredCallbacks` while you're renaming
things?

> Source/WebInspectorUI/UserInterface/Protocol/InspectorBackend.js:178
> +	       setTimeout(callback);

This won't preserve the order of execution, which I'm not sure is something we
entirely care about, but is something to consider nonetheless.	Maybe add a
`_deferredCallbacks` like `WI.Connection`?

Also, instead of directly checking `WI.mainTarget`, could we utilize
`WI.whenTargetsAvailable` to fire all `_deferredCallbacks`?