[webkit-reviews] review granted: [Bug 183040] Separate paint and scroll offsets for RenderLayerBacking::m_scrollingContentsLayer : [Attachment 355474] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Frédéric Wang (:fredw)
<fred.wang at free.fr>'s request for review:
Bug 183040: Separate paint and scroll offsets for
RenderLayerBacking::m_scrollingContentsLayer
https://bugs.webkit.org/show_bug.cgi?id=183040

Attachment 355474: Patch

https://bugs.webkit.org/attachment.cgi?id=355474&action=review




--- Comment #16 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 355474
  --> https://bugs.webkit.org/attachment.cgi?id=355474
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=355474&action=review

>>> Source/WebCore/ChangeLog:8
>>> +	     No new tests, already covered by existing tests.
>> 
>> Can you explain here why the scroll offset needs to be store separately from
the paint offset?
> 
> I'm not exactly sure why it needs to be that way (seem comment 2) but I see
it makes the API cleaner and maybe help to optimize re-display. Can you please
explain the rationale of this FIXME?

Oh ha, that was my fixme. I mean, it makes sense, but do we need to do it to
avoid repaints on composited scroll, for example?