[webkit-reviews] review granted: [Bug 192158] webkitpy: Unify device creation : [Attachment 356031] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Nov 29 12:15:15 PST 2018


Lucas Forschler <lforschler at apple.com> has granted Jonathan Bedard
<jbedard at apple.com>'s request for review:
Bug 192158: webkitpy: Unify device creation
https://bugs.webkit.org/show_bug.cgi?id=192158

Attachment 356031: Patch

https://bugs.webkit.org/attachment.cgi?id=356031&action=review




--- Comment #3 from Lucas Forschler <lforschler at apple.com> ---
Comment on attachment 356031
  --> https://bugs.webkit.org/attachment.cgi?id=356031
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=356031&action=review

lgtm with typo fix

> Tools/Scripts/webkitpy/port/device_port.py:130
> +	       raise RuntimeError('Not enought connected devices for {}
processes'.format(self.child_processes()))

nit: typo enough


More information about the webkit-reviews mailing list