[webkit-reviews] review granted: [Bug 192138] Factor out configuration of the file upload image picker : [Attachment 355983] Patch

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Conrad Shultz
<conrad_shultz at apple.com>'s request for review:
Bug 192138: Factor out configuration of the file upload image picker
https://bugs.webkit.org/show_bug.cgi?id=192138

Attachment 355983: Patch

https://bugs.webkit.org/attachment.cgi?id=355983&action=review




--- Comment #3 from Tim Horton <thorton at apple.com> ---
Comment on attachment 355983
  --> https://bugs.webkit.org/attachment.cgi?id=355983
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=355983&action=review

> Source/WebKit/UIProcess/ios/forms/WKFileUploadPanel.mm:433
> +    ASSERT(_imagePicker);

humorous that you assert the ivar and then use the parameter. why the assert?