[webkit-reviews] review granted: [Bug 192118] Web Inspector: Elements: selecting more than one DOM node causes the scope highlight to contrast : [Attachment 355943] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Nov 28 16:48:47 PST 2018


Devin Rousso <drousso at apple.com> has granted Matt Baker <mattbaker at apple.com>'s
request for review:
Bug 192118: Web Inspector: Elements: selecting more than one DOM node causes
the scope highlight to contrast
https://bugs.webkit.org/show_bug.cgi?id=192118

Attachment 355943: Patch

https://bugs.webkit.org/attachment.cgi?id=355943&action=review




--- Comment #5 from Devin Rousso <drousso at apple.com> ---
Comment on attachment 355943
  --> https://bugs.webkit.org/attachment.cgi?id=355943
Patch

r=me, nice!  Looks great :)

In dark mode, it looks like the current color makes it look pretty awful:

    .tree-outline.dom li.selected + ol.children.expanded {
	border-color: hsl(0, 0%, 27%);
    }

I think we should just remove it.  The value you added in this patch looks fine
in dark mode too 😃


More information about the webkit-reviews mailing list