[webkit-reviews] review granted: [Bug 192109] Web Inspector: Styles: enable selection of multiple properties by default : [Attachment 355937] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Nov 28 16:11:54 PST 2018


Devin Rousso <drousso at apple.com> has granted Nikita Vasilyev
<nvasilyev at apple.com>'s request for review:
Bug 192109: Web Inspector: Styles: enable selection of multiple properties by
default
https://bugs.webkit.org/show_bug.cgi?id=192109

Attachment 355937: Patch

https://bugs.webkit.org/attachment.cgi?id=355937&action=review




--- Comment #3 from Devin Rousso <drousso at apple.com> ---
Comment on attachment 355937
  --> https://bugs.webkit.org/attachment.cgi?id=355937
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=355937&action=review

r=me

>
Source/WebInspectorUI/UserInterface/Views/SpreadsheetCSSStyleDeclarationEditor.
css:53
> +.spreadsheet-style-declaration-editor :matches(.name, .value):not(.editing)
{

Is this rule actually needed?  Can we remove it?

>
Source/WebInspectorUI/UserInterface/Views/SpreadsheetCSSStyleDeclarationEditor.
css:64
> +.spreadsheet-style-declaration-editor :matches(.name, .value):not(.editing)
{

This rule is a duplicate of (53), so please remove it.


More information about the webkit-reviews mailing list