[webkit-reviews] review granted: [Bug 192113] [iOSMac] Dropping text selections from web content into editable elements crashes the web process : [Attachment 355935] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Wenson Hsieh
<wenson_hsieh at apple.com>'s request for review:
Bug 192113: [iOSMac] Dropping text selections from web content into editable
elements crashes the web process
https://bugs.webkit.org/show_bug.cgi?id=192113

Attachment 355935: Patch

https://bugs.webkit.org/attachment.cgi?id=355935&action=review




--- Comment #4 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 355935
  --> https://bugs.webkit.org/attachment.cgi?id=355935
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=355935&action=review

> Source/WebCore/ChangeLog:9
> +	   In iOSMac, registering invalid UTIs on NSItemProvider when starting
a drag or handling a drop fails gracefully.

You mean this doesn't fail gracefully???

> Source/WebCore/platform/ios/PasteboardIOS.mm:200
> -    if ([type isEqualToString:(NSString *)kUTTypeFlatRTFD]) {
> +    if ([type isEqualToString:(__bridge NSString *)kUTTypeFlatRTFD]) {

Can we compile out this code in iOSMac?