[webkit-reviews] review denied: [Bug 192091] Web Inspector: Multiple Selection: restoring selection when opening WebInspector puts the TreeElement into a permanent selected state : [Attachment 355917] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Nov 28 15:12:43 PST 2018


Devin Rousso <drousso at apple.com> has denied Matt Baker <mattbaker at apple.com>'s
request for review:
Bug 192091: Web Inspector: Multiple Selection: restoring selection when opening
WebInspector puts the TreeElement into a permanent selected state
https://bugs.webkit.org/show_bug.cgi?id=192091

Attachment 355917: Patch

https://bugs.webkit.org/attachment.cgi?id=355917&action=review




--- Comment #3 from Devin Rousso <drousso at apple.com> ---
Comment on attachment 355917
  --> https://bugs.webkit.org/attachment.cgi?id=355917
Patch

r-, this doesn't fix the issue.

Another reproduction case:
1. open WebInspector
2. enable the Audit tab
3. select "Demo Audit" > "Result Data" > "data-domNodes"
4. close WebInspector
5. reopen WebInspector
6. select "Demo Audit" > "Result Levels" > "level-unsupported"
 => both "data-domNodes" and "level-unsupported" are selected


More information about the webkit-reviews mailing list