[webkit-reviews] review granted: [Bug 192076] Remove some superfluous code in ContentSecurityPolicy::upgradeInsecureRequestIfNeeded : [Attachment 355870] Patch

[bugzilla-daemon at webkit.org]

Frédéric Wang (:fredw) <fred.wang at free.fr> has granted Rob Buis
<rbuis at igalia.com>'s request for review:
Bug 192076: Remove some superfluous code in
ContentSecurityPolicy::upgradeInsecureRequestIfNeeded
https://bugs.webkit.org/show_bug.cgi?id=192076

Attachment 355870: Patch

https://bugs.webkit.org/attachment.cgi?id=355870&action=review




--- Comment #2 from Frédéric Wang (:fredw) <fred.wang at free.fr> ---
Comment on attachment 355870
  --> https://bugs.webkit.org/attachment.cgi?id=355870
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=355870&action=review

> Source/WebCore/ChangeLog:12
> +

maybe mention the early return at the beginning of the function.

> Source/WebCore/page/csp/ContentSecurityPolicy.cpp:885
> +

unnecessary whitespace change.

> Source/WebCore/page/csp/ContentSecurityPolicy.cpp:-894
> -	   return;

I wonder if we want an ASSERT(url.protocolIs("ws")) or ASSERT_NOT_REACHED
instead, to prevent potential mistakes if new protocols are added in the
future.