[webkit-reviews] review requested: [Bug 191931] [ews-app] Add methods to update Patch fields : [Attachment 355891] Updated patch

[bugzilla-daemon at webkit.org]

Aakash Jain <aakash_jain at apple.com> has asked  for review:
Bug 191931: [ews-app] Add methods to update Patch fields
https://bugs.webkit.org/show_bug.cgi?id=191931

Attachment 355891: Updated patch

https://bugs.webkit.org/attachment.cgi?id=355891&action=review




--- Comment #4 from Aakash Jain <aakash_jain at apple.com> ---
Created attachment 355891

  --> https://bugs.webkit.org/attachment.cgi?id=355891&action=review

Updated patch

> I'm not sure if I like using 'bb' as an abbreviation for buildbot.
Expanded bb to buildbot.

> Also... 'set' could be read multiple ways.
Not sure what might be a good alternative. mark_set_to_buildbot or
set_property_sent_to_buildbot doesn't look good as well. Kept as is for now.

> could sent_to_bb be a boolean?
It is a boolean.