[webkit-reviews] review granted: [Bug 192026] [WebRTC][GStreamer] Make sure to have the default microphone on the top of the list : [Attachment 355759] Patch

[bugzilla-daemon at webkit.org]

Philippe Normand <pnormand at igalia.com> has granted Thibault Saunier
<tsaunier at gnome.org>'s request for review:
Bug 192026: [WebRTC][GStreamer] Make sure to have the default microphone on the
top of the list
https://bugs.webkit.org/show_bug.cgi?id=192026

Attachment 355759: Patch

https://bugs.webkit.org/attachment.cgi?id=355759&action=review




--- Comment #2 from Philippe Normand <pnormand at igalia.com> ---
Comment on attachment 355759
  --> https://bugs.webkit.org/attachment.cgi?id=355759
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=355759&action=review

Looks good, just a couple nits

> Source/WebCore/ChangeLog:8
> +	   [WebRTC][GStreamer] Make sure to have the default microphone on the
top of the list

Remove this :)

>
Source/WebCore/platform/mediastream/gstreamer/GStreamerCaptureDeviceManager.cpp
:33
> +static gint
> +sortDevices(gconstpointer a, gconstpointer b)
> +{

In one line please!