[webkit-reviews] review requested: [Bug 191947] [ews-app] Fetch bugs from Bugzilla and submit to Buildbot : [Attachment 355861] Updated patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Nov 28 04:04:58 PST 2018


Aakash Jain <aakash_jain at apple.com> has asked  for review:
Bug 191947: [ews-app] Fetch bugs from Bugzilla and submit to Buildbot
https://bugs.webkit.org/show_bug.cgi?id=191947

Attachment 355861: Updated patch

https://bugs.webkit.org/attachment.cgi?id=355861&action=review




--- Comment #3 from Aakash Jain <aakash_jain at apple.com> ---
Created attachment 355861

  --> https://bugs.webkit.org/attachment.cgi?id=355861&action=review

Updated patch

> Should we call this BugzillaPatchFetcher for descriptiveness?
Changed. Not sure if we should rename the file as well. It would be too long
for file name. I guess we can leave the file name as is.

> Since it's not only validating but also removing we can probably call this:
`filter_valid_patches(cls, patch_ids)`.
Done.

> Sounds like we can use `filter()` for this.
Done.


More information about the webkit-reviews mailing list