[webkit-reviews] review granted: [Bug 192054] Modernize version checks for same site cookie support : [Attachment 355816] proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Nov 27 18:30:37 PST 2018


Tim Horton <thorton at apple.com> has granted Alexey Proskuryakov
<ap at webkit.org>'s request for review:
Bug 192054: Modernize version checks for same site cookie support
https://bugs.webkit.org/show_bug.cgi?id=192054

Attachment 355816: proposed patch

https://bugs.webkit.org/attachment.cgi?id=355816&action=review




--- Comment #2 from Tim Horton <thorton at apple.com> ---
Comment on attachment 355816
  --> https://bugs.webkit.org/attachment.cgi?id=355816
proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=355816&action=review

This one seems reasonable.

> Source/WTF/wtf/Platform.h:1384
> +/* FIXME: Should this be enabled or IOS_FAMILY, not just IOS? */

Surely, no?


More information about the webkit-reviews mailing list