[webkit-reviews] review granted: [Bug 191974] webkitpy: Add watchOS ports : [Attachment 355668] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Nov 27 14:06:17 PST 2018


Aakash Jain <aakash_jain at apple.com> has granted Jonathan Bedard
<jbedard at apple.com>'s request for review:
Bug 191974: webkitpy: Add watchOS ports
https://bugs.webkit.org/show_bug.cgi?id=191974

Attachment 355668: Patch

https://bugs.webkit.org/attachment.cgi?id=355668&action=review




--- Comment #5 from Aakash Jain <aakash_jain at apple.com> ---
Comment on attachment 355668
  --> https://bugs.webkit.org/attachment.cgi?id=355668
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=355668&action=review

> Tools/Scripts/webkitpy/port/watch.py:23
> +

Nit: Do we need 2 or 1 empty lines here?

> Tools/Scripts/webkitpy/port/watch.py:103
> +	   # The implementation of this funciton differs between on-device and
simulator testing.

typo: funciton => function


More information about the webkit-reviews mailing list