[webkit-reviews] review granted: [Bug 191866] Better parsing of comments in generate-message*.py : [Attachment 355358] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has granted Keith Rollin <krollin at apple.com>'s
request for review:
Bug 191866: Better parsing of comments in generate-message*.py
https://bugs.webkit.org/show_bug.cgi?id=191866

Attachment 355358: Patch

https://bugs.webkit.org/attachment.cgi?id=355358&action=review




--- Comment #3 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 355358
  --> https://bugs.webkit.org/attachment.cgi?id=355358
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=355358&action=review

r=me

> Source/WebKit/Scripts/Makefile:8
> +	grep FakeLoadURL webkit/*-expected.* && "### Test failure: found
commented-out functions in output" || true

I do not think we need this check here. Since you added comments to
test-messages.in and webkit/MessageReceiver-expected.cpp did not change, it is
validation enough.