[webkit-reviews] review granted: [Bug 192013] Introducing a ENABLE_SEPARATED_WX_HEAP macro. : [Attachment 355749] proposed patch.

[bugzilla-daemon at webkit.org]

Keith Miller <keith_miller at apple.com> has granted Mark Lam
<mark.lam at apple.com>'s request for review:
Bug 192013: Introducing a ENABLE_SEPARATED_WX_HEAP macro.
https://bugs.webkit.org/show_bug.cgi?id=192013

Attachment 355749: proposed patch.

https://bugs.webkit.org/attachment.cgi?id=355749&action=review




--- Comment #2 from Keith Miller <keith_miller at apple.com> ---
Comment on attachment 355749
  --> https://bugs.webkit.org/attachment.cgi?id=355749
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=355749&action=review

r=me.

> Source/JavaScriptCore/config.h:41
> +#if !defined(ENABLE_SEPARATED_WX_HEAP)

Nit: why not #ifndef?

> Source/JavaScriptCore/config.h:42
> +#if (!ENABLE(FAST_JIT_PERMISSIONS) || !CPU(ARM64E)) && PLATFORM(IOS_FAMILY)
&& CPU(ARM64)

Nit: Can we make this !(ENABLE(FAST_JIT_PERMISSIONS) && CPU(ARM64E)) &&
PLATFORM(IOS_FAMILY) && CPU(ARM64)?

I prefer to pull the negations out since I find it easier to read the inside of
the parens then negate.