[webkit-reviews] review granted: [Bug 191751] Prevent recursion while creating media controls : [Attachment 355742] Patch

[bugzilla-daemon at webkit.org]

Dean Jackson <dino at apple.com> has granted Eric Carlson
<eric.carlson at apple.com>'s request for review:
Bug 191751: Prevent recursion while creating media controls
https://bugs.webkit.org/show_bug.cgi?id=191751

Attachment 355742: Patch

https://bugs.webkit.org/attachment.cgi?id=355742&action=review




--- Comment #14 from Dean Jackson <dino at apple.com> ---
Comment on attachment 355742
  --> https://bugs.webkit.org/attachment.cgi?id=355742
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=355742&action=review

> Source/WebCore/Modules/modern-media-controls/media/media-controller.js:121
> +	   window.requestAnimationFrame(() => this._updateControlsSize());

You don't need the "window." part.

> Source/WebCore/Modules/modern-media-controls/media/media-controller.js:202
> +		   window.requestAnimationFrame(() =>
this._updateControlsSize());

or here.

> Source/WebCore/Modules/modern-media-controls/media/media-controller.js:230
> +	       window.requestAnimationFrame(() => this._updateControlsSize());

or here.