[webkit-reviews] review granted: [Bug 191981] Rename WKWebView._safeBrowsingWarningForTesting to _safeBrowsingWarning to use it for more than testing : [Attachment 355680] Patch

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 191981: Rename WKWebView._safeBrowsingWarningForTesting to
_safeBrowsingWarning to use it for more than testing
https://bugs.webkit.org/show_bug.cgi?id=191981

Attachment 355680: Patch

https://bugs.webkit.org/attachment.cgi?id=355680&action=review




--- Comment #2 from Tim Horton <thorton at apple.com> ---
Comment on attachment 355680
  --> https://bugs.webkit.org/attachment.cgi?id=355680
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=355680&action=review

> Source/WebKit/UIProcess/API/Cocoa/WKWebViewPrivate.h:474
> - at property (nonatomic, readonly) UIView *_safeBrowsingWarningForTesting
WK_API_AVAILABLE(macosx(WK_MAC_TBA), ios(WK_IOS_TBA));
> + at property (nonatomic, readonly) UIView *_safeBrowsingWarning
WK_API_AVAILABLE(macosx(WK_MAC_TBA), ios(WK_IOS_TBA));

If you're going to 'use it for more than just testing', you need to move it out
of the WKTesting category too.