[webkit-reviews] review granted: [Bug 191948] [Cocoa] Make it easier to encode NSObjects for WebKit IPC : [Attachment 355649] Patch

[bugzilla-daemon at webkit.org]

Dean Jackson <dino at apple.com> has granted Andy Estes <aestes at apple.com>'s
request for review:
Bug 191948: [Cocoa] Make it easier to encode NSObjects for WebKit IPC
https://bugs.webkit.org/show_bug.cgi?id=191948

Attachment 355649: Patch

https://bugs.webkit.org/attachment.cgi?id=355649&action=review




--- Comment #9 from Dean Jackson <dino at apple.com> ---
Comment on attachment 355649
  --> https://bugs.webkit.org/attachment.cgi?id=355649
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=355649&action=review

Cool patch!

> Source/WebCore/Modules/applepay/cocoa/PaymentCocoa.mm:70
> +Payment::Payment() = default;

Why did you move this to the implementation?

> Source/WebKit/Shared/Cocoa/ArgumentCodersCocoa.h:57
> +    ASSERT([object isKindOfClass:allowedClasses[0]]);

Maybe ASSERT allowedClasses has entries?

> Source/WebKit/Shared/Cocoa/ArgumentCodersCocoa.h:58
> +    return { adoptNS((T *)object) };

Can you static_cast here?