[webkit-reviews] review granted: [Bug 191622] Web Inspector: Remove unused DataGrid and TreeOutline code : [Attachment 354857] Patch

[bugzilla-daemon at webkit.org]

Devin Rousso <drousso at apple.com> has granted Matt Baker <mattbaker at apple.com>'s
request for review:
Bug 191622: Web Inspector: Remove unused DataGrid and TreeOutline code
https://bugs.webkit.org/show_bug.cgi?id=191622

Attachment 354857: Patch

https://bugs.webkit.org/attachment.cgi?id=354857&action=review




--- Comment #5 from Devin Rousso <drousso at apple.com> ---
Comment on attachment 354857
  --> https://bugs.webkit.org/attachment.cgi?id=354857
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=354857&action=review

r=me

> Source/WebInspectorUI/UserInterface/Views/ErrorObjectView.css:61
> +    -webkit-padding-start: 16px

Did you test this in RTL?  Is this the correct behavior?

> Source/WebInspectorUI/UserInterface/Views/ErrorObjectView.js:2
> + * Copyright (C) 2015-2018 Apple Inc. All rights reserved.

I'm not sure what our "style" is on this, but I've heard both that "it should
only be the most recent year" and "it should be every year it was significantly
modified".  Maybe confirm which is preferred?