[webkit-reviews] review granted: [Bug 191659] Web Inspector: Audit: automatically add to tab bar when the experimental setting is enabled : [Attachment 355606] Patch

[bugzilla-daemon at webkit.org]

Joseph Pecoraro <joepeck at webkit.org> has granted Devin Rousso
<drousso at apple.com>'s request for review:
Bug 191659: Web Inspector: Audit: automatically add to tab bar when the
experimental setting is enabled
https://bugs.webkit.org/show_bug.cgi?id=191659

Attachment 355606: Patch

https://bugs.webkit.org/attachment.cgi?id=355606&action=review




--- Comment #5 from Joseph Pecoraro <joepeck at webkit.org> ---
Comment on attachment 355606
  --> https://bugs.webkit.org/attachment.cgi?id=355606
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=355606&action=review

r=me

> Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.js:267
> +	       let newTabs = WI._openTabsSetting.value.slice();

Maybe move this to WI.settings, or public? It’s default value though uses a
bunch of other classes.