[webkit-reviews] review granted: [Bug 191938] [css-grid] grid abs.pos. child is sized wrongly when using auto-fit and it generates some collapsed tracks : [Attachment 355560] Patch

[bugzilla-daemon at webkit.org]

Manuel Rego Casasnovas <rego at igalia.com> has granted Javier Fernandez
<jfernandez at igalia.com>'s request for review:
Bug 191938: [css-grid] grid abs.pos. child is sized wrongly when using auto-fit
and it generates some collapsed tracks
https://bugs.webkit.org/show_bug.cgi?id=191938

Attachment 355560: Patch

https://bugs.webkit.org/attachment.cgi?id=355560&action=review




--- Comment #4 from Manuel Rego Casasnovas <rego at igalia.com> ---
Comment on attachment 355560
  --> https://bugs.webkit.org/attachment.cgi?id=355560
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=355560&action=review

Thanks for fixing this. If this was fixed before in Blink could you link the
bug from "See also" field?

> Source/WebCore/ChangeLog:3
> +	   [css-grid] grid abs.pos. child is sized wrongly when using auto-fit
and it generates some collapsed tracks

Nit: This title might be reworded :-)

> Source/WebCore/rendering/RenderGrid.cpp:395
> +	       // We shouldn't count the gap if the the span starts and ends in
a collapsed but there isn't non-empty tracks afterwards (it's at the end of the
grid).

Nit: s/collapsed/collapsed track/