[webkit-reviews] review granted: [Bug 191953] Remote tile layers shouldn't be UIViews : [Attachment 355599] patch

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Antti Koivisto <koivisto at iki.fi>'s
request for review:
Bug 191953: Remote tile layers shouldn't be UIViews
https://bugs.webkit.org/show_bug.cgi?id=191953

Attachment 355599: patch

https://bugs.webkit.org/attachment.cgi?id=355599&action=review




--- Comment #7 from Tim Horton <thorton at apple.com> ---
Comment on attachment 355599
  --> https://bugs.webkit.org/attachment.cgi?id=355599
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=355599&action=review

> Source/WebKit/UIProcess/RemoteLayerTree/RemoteLayerTreeNode.mm:75
> +    if (uiView()) {

Maybe grab it and store it in a local? ('if (auto view = uiView()) [view
removeFromSuperview];') It likely doesn't matter, but it seems nicer.

> Source/WebKit/UIProcess/RemoteLayerTree/RemoteLayerTreeNode.mm:95
> +NSString* RemoteLayerTreeNode::appendLayerDescription(NSString* description,
CALayer* layer)

Star's on the wrong side. (seems like this file is full of that)