[webkit-reviews] review denied: [Bug 191659] Web Inspector: Audit: automatically add to tab bar when the experimental setting is enabled : [Attachment 354856] Patch

[bugzilla-daemon at webkit.org]

Matt Baker <mattbaker at apple.com> has denied Devin Rousso <drousso at apple.com>'s
request for review:
Bug 191659: Web Inspector: Audit: automatically add to tab bar when the
experimental setting is enabled
https://bugs.webkit.org/show_bug.cgi?id=191659

Attachment 354856: Patch

https://bugs.webkit.org/attachment.cgi?id=354856&action=review




--- Comment #2 from Matt Baker <mattbaker at apple.com> ---
Comment on attachment 354856
  --> https://bugs.webkit.org/attachment.cgi?id=354856
Patch

Does this need to be rebased? it doesn't apply locally for me, and doesn't
match trunk:
https://trac.webkit.org/browser/webkit/trunk/Source/WebInspectorUI/UserInterfac
e/Views/SettingsTabContentView.js

That aside, I like the idea of automatically adding tabs when enabling the
corresponding experimental setting. i wonder about the following case though:

- User enables the Layers Tab (for example)
- Layers tab is automatically added
- User hides Layers tab, leaving the setting enabled
- Reload Web Inspector

=> Layers tab will be added again

Ideally we would want to honor the user's decision to hide the tab. Maybe this
isn't an issue, since these are experimental features.