[webkit-reviews] review granted: [Bug 191918] [Cocoa] Add WKWebView SPI to trigger and remove data detection : [Attachment 355533] Fix the GTK build

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Wenson Hsieh
<wenson_hsieh at apple.com>'s request for review:
Bug 191918: [Cocoa] Add WKWebView SPI to trigger and remove data detection
https://bugs.webkit.org/show_bug.cgi?id=191918

Attachment 355533: Fix the GTK build

https://bugs.webkit.org/attachment.cgi?id=355533&action=review




--- Comment #7 from Tim Horton <thorton at apple.com> ---
Comment on attachment 355533
  --> https://bugs.webkit.org/attachment.cgi?id=355533
Fix the GTK build

View in context: https://bugs.webkit.org/attachment.cgi?id=355533&action=review

> Source/WebKit/UIProcess/API/Cocoa/WKWebViewPrivate.h:197
> +- (void)_removeAllDataDetectedContent:(dispatch_block_t)completion
WK_API_AVAILABLE(macosx(WK_MAC_TBA), ios(WK_IOS_TBA));

Also, why is one available on both platforms and the other only on iOS?

> Source/WebKit/WebProcess/WebPage/WebPage.cpp:3396
> +void WebPage::removeAllDataDetectedContent(CallbackID callbackID)

Didn't Alex invent some new thing to replace CallbackID? See
https://trac.webkit.org/changeset/237294/webkit