[webkit-reviews] review requested: [Bug 156271] Web Inspector: CSS autocomplete: suggestion hint should be the most commonly used property and not the alphabetically first one : [Attachment 355544] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Nov 23 17:58:25 PST 2018
Devin Rousso <drousso at apple.com> has asked for review:
Bug 156271: Web Inspector: CSS autocomplete: suggestion hint should be the most
commonly used property and not the alphabetically first one
https://bugs.webkit.org/show_bug.cgi?id=156271
Attachment 355544: Patch
https://bugs.webkit.org/attachment.cgi?id=355544&action=review
--- Comment #21 from Devin Rousso <drousso at apple.com> ---
Created attachment 355544
--> https://bugs.webkit.org/attachment.cgi?id=355544&action=review
Patch
When running tests, since `WI.ObjectStore.supported()` is `false`, the value
never gets saved, meaning calling `get()` will return `undefined`.
`WI.CSSProperty.prototype._updateName` would default to using `0` in this case,
which wouldn't work for the test as the cached value would already be `1`.
Instead, we should default to using the cached value if the `get()` doesn't
work.
More information about the webkit-reviews
mailing list