[webkit-reviews] review granted: [Bug 191927] Replace LayerOrView typedef with a class : [Attachment 355531] patch

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Antti Koivisto <koivisto at iki.fi>'s
request for review:
Bug 191927: Replace LayerOrView typedef with a class
https://bugs.webkit.org/show_bug.cgi?id=191927

Attachment 355531: patch

https://bugs.webkit.org/attachment.cgi?id=355531&action=review




--- Comment #4 from Tim Horton <thorton at apple.com> ---
Comment on attachment 355531
  --> https://bugs.webkit.org/attachment.cgi?id=355531
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=355531&action=review

Seems reasonable.

> Source/WebKit/ChangeLog:9
> +	   have more flexibility, for example tiles don't really need to be
UIViews. It will also make it easier

If you do make the view-ness optional, please add an ASSERTion that we never
parent a view under a raw layer.