[webkit-reviews] review granted: [Bug 191908] UI side compositing doesn't paint on Mac : [Attachment 355479] with HAVE_IOSURFACE_RGB10

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Nov 22 15:10:22 PST 2018


Tim Horton <thorton at apple.com> has granted Antti Koivisto <koivisto at iki.fi>'s
request for review:
Bug 191908: UI side compositing doesn't paint on Mac
https://bugs.webkit.org/show_bug.cgi?id=191908

Attachment 355479: with HAVE_IOSURFACE_RGB10

https://bugs.webkit.org/attachment.cgi?id=355479&action=review




--- Comment #5 from Tim Horton <thorton at apple.com> ---
Comment on attachment 355479
  --> https://bugs.webkit.org/attachment.cgi?id=355479
with HAVE_IOSURFACE_RGB10

View in context: https://bugs.webkit.org/attachment.cgi?id=355479&action=review

> Source/WebKit/Shared/RemoteLayerTree/RemoteLayerBackingStore.mm:505
> +#if HAVE(IOSURFACE_RGB10)

All seems a bit overkill when you could have just done this one.

Also we probably want something different here so we're not just using RGBA on
wide-color macOS? But that's a separate problem.


More information about the webkit-reviews mailing list