[webkit-reviews] review granted: [Bug 191911] Implement WebGPUQueue and device.getQueue() : [Attachment 355478] Patch

[bugzilla-daemon at webkit.org]

Antoine Quint <graouts at apple.com> has granted Dean Jackson <dino at apple.com>'s
request for review:
Bug 191911: Implement WebGPUQueue and device.getQueue()
https://bugs.webkit.org/show_bug.cgi?id=191911

Attachment 355478: Patch

https://bugs.webkit.org/attachment.cgi?id=355478&action=review




--- Comment #3 from Antoine Quint <graouts at apple.com> ---
Comment on attachment 355478
  --> https://bugs.webkit.org/attachment.cgi?id=355478
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=355478&action=review

> Source/WebCore/Modules/webgpu/WebGPUQueue.cpp:54
> +	   gpuBuffers.append(buffer->commandBuffer());

This could use Vector::map().

> Source/WebCore/Modules/webgpu/WebGPUQueue.idl:30
> +    ImplementationLacksVTable

Is this necessary?

> Source/WebCore/platform/graphics/gpu/cocoa/GPUQueueMetal.mm:59
> +	   LOG(WebGPU, "GPUQueue::create(): Unable to create
MTLCommandQueue.");

So much better.

> LayoutTests/webgpu/queue-creation.html:15
> +    const swapChain = canvas.getContext("webgpu");

Remove the canvas variable and do it in a single statement.

> LayoutTests/webgpu/queue-creation.html:29
> +}, "getQueue() on WebGPUDevice");

I would put a full stop at the end of all those assertions.