[webkit-reviews] review granted: [Bug 191861] [GStreamer][WebRTC] Use LibWebRTC provided vp8 decoders and encoders : [Attachment 355467] Minor ChangeLog enhancement

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Nov 22 06:09:07 PST 2018


Philippe Normand <pnormand at igalia.com> has granted Thibault Saunier
<tsaunier at gnome.org>'s request for review:
Bug 191861: [GStreamer][WebRTC] Use LibWebRTC provided vp8 decoders and
encoders
https://bugs.webkit.org/show_bug.cgi?id=191861

Attachment 355467: Minor ChangeLog enhancement

https://bugs.webkit.org/attachment.cgi?id=355467&action=review




--- Comment #7 from Philippe Normand <pnormand at igalia.com> ---
Comment on attachment 355467
  --> https://bugs.webkit.org/attachment.cgi?id=355467
Minor ChangeLog enhancement

View in context: https://bugs.webkit.org/attachment.cgi?id=355467&action=review

> Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.h:142
> +    GstMappedFrame(GstBuffer *buffer, GstVideoInfo info, GstMapFlags flags)

Nit: misplaced *s in all this class

>
Source/WebCore/platform/mediastream/gstreamer/GStreamerVideoFrameLibWebRTC.cpp:
24
> +#include<thread>

I didn't know the space is optional in #includes :)


More information about the webkit-reviews mailing list