[webkit-reviews] review granted: [Bug 191896] [LFC] LayoutState should always be initialized with the initial containing block. : [Attachment 355440] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Nov 21 15:12:10 PST 2018


Antti Koivisto <koivisto at iki.fi> has granted zalan <zalan at apple.com>'s request
for review:
Bug 191896: [LFC] LayoutState should always be initialized with the initial
containing block.
https://bugs.webkit.org/show_bug.cgi?id=191896

Attachment 355440: Patch

https://bugs.webkit.org/attachment.cgi?id=355440&action=review




--- Comment #2 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 355440
  --> https://bugs.webkit.org/attachment.cgi?id=355440
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=355440&action=review

> Source/WebCore/layout/Verification.cpp:324
> +    auto& initialContainingBlock = *m_initialContainingBlock;

The local here doesn't do much.


More information about the webkit-reviews mailing list