[webkit-reviews] review granted: [Bug 191776] Creating a wasm memory that is bigger than the ArrayBuffer limit but smaller than the spec limit should throw OOME not RangeError : [Attachment 355436] proposed patch.

[bugzilla-daemon at webkit.org]

Saam Barati <sbarati at apple.com> has granted Mark Lam <mark.lam at apple.com>'s
request for review:
Bug 191776: Creating a wasm memory that is bigger than the ArrayBuffer limit
but smaller than the spec limit should throw OOME not RangeError
https://bugs.webkit.org/show_bug.cgi?id=191776

Attachment 355436: proposed patch.

https://bugs.webkit.org/attachment.cgi?id=355436&action=review




--- Comment #3 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 355436
  --> https://bugs.webkit.org/attachment.cgi?id=355436
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=355436&action=review

>
JSTests/wasm/regress/wasm-memory-requested-more-than-MAX_ARRAY_BUFFER_SIZE-2.js
:88
> +var exception;
> +try {
> +    var module = new WasmModuleBuilder();
> +    module.addMemory(32768);
> +    module.instantiate();
> +} catch (e) {
> +    exception = e;
> +}
> +
> +if (exception != "Error: Out of memory") {
> +    print(exception);
> +    throw "FAILED";
> +}

Why not just write this as a wasm test so you're not copying part of the module
builder?