[webkit-reviews] review granted: [Bug 191892] [SOUP] Follow-up robustness improvements to the certificate decoder : [Attachment 355427] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Nov 21 10:41:54 PST 2018
Michael Catanzaro <mcatanzaro at igalia.com> has granted Claudio Saavedra
<csaavedra at igalia.com>'s request for review:
Bug 191892: [SOUP] Follow-up robustness improvements to the certificate decoder
https://bugs.webkit.org/show_bug.cgi?id=191892
Attachment 355427: Patch
https://bugs.webkit.org/attachment.cgi?id=355427&action=review
--- Comment #3 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 355427
--> https://bugs.webkit.org/attachment.cgi?id=355427
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=355427&action=review
Yes and yes, good catches.
> Source/WebCore/ChangeLog:10
> + is nil, return false from the decoder to notify the failure
null, what language are you working with here :P
More information about the webkit-reviews
mailing list