[webkit-reviews] review granted: [Bug 191881] Tables with vertical-lr writing-mode doesn't apply correctly vertical-align: baseline : [Attachment 355411] Patch

[bugzilla-daemon at webkit.org]

Manuel Rego Casasnovas <rego at igalia.com> has granted Javier Fernandez
<jfernandez at igalia.com>'s request for review:
Bug 191881: Tables with vertical-lr writing-mode doesn't apply correctly
vertical-align: baseline
https://bugs.webkit.org/show_bug.cgi?id=191881

Attachment 355411: Patch

https://bugs.webkit.org/attachment.cgi?id=355411&action=review




--- Comment #5 from Manuel Rego Casasnovas <rego at igalia.com> ---
Comment on attachment 355411
  --> https://bugs.webkit.org/attachment.cgi?id=355411
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=355411&action=review

LGTM, I guess you still need to add the new results for other platforms before
landing.

>
LayoutTests/fast/writing-mode/vertical-align-table-baseline-latin-expected.html
:8
> +</style>

Nit: I'd add the typical paragraph about when this passes.