[webkit-reviews] review granted: [Bug 191873] [LFC][IFC] Take nonBreakableStart/End into use. : [Attachment 355383] Patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted zalan <zalan at apple.com>'s request
for review:
Bug 191873: [LFC][IFC] Take nonBreakableStart/End into use.
https://bugs.webkit.org/show_bug.cgi?id=191873

Attachment 355383: Patch

https://bugs.webkit.org/attachment.cgi?id=355383&action=review




--- Comment #2 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 355383
  --> https://bugs.webkit.org/attachment.cgi?id=355383
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=355383&action=review

> Source/WebCore/layout/inlineformatting/InlineFormattingContext.cpp:148
>      unsigned uncommittedLength = 0;
>      InlineItem* firstUncommittedInlineItem = nullptr;
> +    InlineItem* lastUncommittedInlineItem = nullptr;

Maybe these could alternatively be something like

struct Uncommitted { unsigned length { 0 }; InlineItem& firstInlineItem;
InlineItem& lastInlineItem; };
std::optional<Uncommitted> uncommitted;

since these are always used together?