[webkit-reviews] review granted: [Bug 191874] Mutation observers doesn't get notified of character data mutation made by the parser : [Attachment 355381] Fixes the bug

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 191874: Mutation observers doesn't get notified of character data mutation
made by the parser
https://bugs.webkit.org/show_bug.cgi?id=191874

Attachment 355381: Fixes the bug

https://bugs.webkit.org/attachment.cgi?id=355381&action=review




--- Comment #2 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 355381
  --> https://bugs.webkit.org/attachment.cgi?id=355381
Fixes the bug

View in context: https://bugs.webkit.org/attachment.cgi?id=355381&action=review

> Source/WebCore/dom/CharacterData.cpp:102
> +    String oldData;
> +    if (UNLIKELY(mutationRecipients))
> +	   oldData = m_data;

Maybe just set oldData unconditionally? It is not clear that a branch is faster
than minor ref churn.