[webkit-reviews] review denied: [Bug 191443] CSS Painting API should pass 'this' correctly to paint callback, and repaint when properties change. : [Attachment 355114] Patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has denied  review:
Bug 191443: CSS Painting API should pass 'this' correctly to paint callback,
and repaint when properties change.
https://bugs.webkit.org/show_bug.cgi?id=191443

Attachment 355114: Patch

https://bugs.webkit.org/attachment.cgi?id=355114&action=review




--- Comment #40 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 355114
  --> https://bugs.webkit.org/attachment.cgi?id=355114
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=355114&action=review

Please put RenderStyle related changes to a separate patch.

> Source/WebCore/rendering/style/RenderStyle.h:1890
> +#if ENABLE(CSS_PAINTING_API)
> +    bool m_hasCustomPaintWatchProperties { false };
> +#endif

I don't see any reason why this bit is super special and needs to be in the
RenderStyle, necessitating custom copy constructors, operator== etc.

It should go to one of the substructures, probably RareNonInheritedData. There
is already StyleCustomPropertyData instance there, so maybe that is the place?
Also you don't need to use bit-and-side-hash approach. You can just put the
hash there.