[webkit-reviews] review granted: [Bug 191548] Enable JIT on ARM/Linux : [Attachment 355356] Patch

[bugzilla-daemon at webkit.org]

Yusuke Suzuki <yusukesuzuki at slowstart.org> has granted Dominik Inführ
<dinfuehr at igalia.com>'s request for review:
Bug 191548: Enable JIT on ARM/Linux
https://bugs.webkit.org/show_bug.cgi?id=191548

Attachment 355356: Patch

https://bugs.webkit.org/attachment.cgi?id=355356&action=review




--- Comment #8 from Yusuke Suzuki <yusukesuzuki at slowstart.org> ---
Comment on attachment 355356
  --> https://bugs.webkit.org/attachment.cgi?id=355356
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=355356&action=review

r=me

> Source/JavaScriptCore/bytecode/InstructionStream.cpp:49
> +    const Instruction* begin = at(0).ptr();
> +    const Instruction* end = reinterpret_cast<const
Instruction*>(reinterpret_cast<const uint8_t*>(begin) + size());
> +
> +    return instruction >= begin && instruction < end;

Actually, you do not need to use `Instruction*` here. You can define this
function simply by,

const uint8_t* pointer = bitwise_cast<const uint8_t*>(instruction);
return pointer >= m_instructions.data() && pointer < (m_instructions.data() +
m_instructions.size());

> Source/JavaScriptCore/jit/GPRInfo.h:531
> +#define NUMBER_OF_CALLEE_SAVES_REGISTERS 1u

This is only correct for ARM_THUMB2.