[webkit-reviews] review denied: [Bug 191862] [WPE][GTK] Add API to enable and disable Unified Plan SDP : [Attachment 355342] Patch

[bugzilla-daemon at webkit.org]

Michael Catanzaro <mcatanzaro at igalia.com> has denied Thibault Saunier
<tsaunier at gnome.org>'s request for review:
Bug 191862: [WPE][GTK] Add API to enable and disable Unified Plan SDP
https://bugs.webkit.org/show_bug.cgi?id=191862

Attachment 355342: Patch

https://bugs.webkit.org/attachment.cgi?id=355342&action=review




--- Comment #3 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 355342
  --> https://bugs.webkit.org/attachment.cgi?id=355342
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=355342&action=review

This API won't do anything because WebRTC is still not enabled in release
builds. There is no value in adding more API that will be broken on day one.
It's bad enough that we already have the enable-media-stream setting in our
API. I think this should be revisited after we have enabled WebRTC.

> Source/WebKit/UIProcess/API/glib/WebKitSettings.cpp:1307
> +	* Enable Unified Plan for specifying multiple media source in SDP
> +	* (instead of Plan B).

Needs more detail. What does it mean; what does it do?

> Source/WebKit/UIProcess/API/glib/WebKitSettings.cpp:1315
> +	       _("Enable webrtc unfied plan"),
> +	       _("Whether to renable webrtc unified plan."),

WebRTC unified

> Source/WebKit/UIProcess/API/gtk/WebKitSettings.h:421
> +webkit_settings_set_enable_webrtc_unified_plan		 
(WebKitSettings* settings,
> +								   gboolean
enabled);

align the parameters