[webkit-reviews] review granted: [Bug 191694] Click on node assigned to slot in button's shadow cause loss of button focus : [Attachment 355308] Fixes the bug

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Nov 19 21:44:26 PST 2018


Wenson Hsieh <wenson_hsieh at apple.com> has granted Ryosuke Niwa
<rniwa at webkit.org>'s request for review:
Bug 191694: Click on node assigned to slot in button's shadow cause loss of
button focus
https://bugs.webkit.org/show_bug.cgi?id=191694

Attachment 355308: Fixes the bug

https://bugs.webkit.org/attachment.cgi?id=355308&action=review




--- Comment #4 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 355308
  --> https://bugs.webkit.org/attachment.cgi?id=355308
Fixes the bug

r=mews

As an aside, it looks like there's similar logic in
FrameSelection::setFocusedElementIfNeeded() that attempts to walk up the DOM in
search of an element to focus.


More information about the webkit-reviews mailing list