[webkit-reviews] review granted: [Bug 191792] globalFuncImportModule() should return a promise when it clears exceptions. : [Attachment 355290] proposed patch w/ test failure fixes.

[bugzilla-daemon at webkit.org]

Michael Saboff <msaboff at apple.com> has granted Mark Lam <mark.lam at apple.com>'s
request for review:
Bug 191792: globalFuncImportModule() should return a promise when it clears
exceptions.
https://bugs.webkit.org/show_bug.cgi?id=191792

Attachment 355290: proposed patch w/ test failure fixes.

https://bugs.webkit.org/attachment.cgi?id=355290&action=review




--- Comment #17 from Michael Saboff <msaboff at apple.com> ---
Comment on attachment 355290
  --> https://bugs.webkit.org/attachment.cgi?id=355290
proposed patch w/ test failure fixes.

View in context: https://bugs.webkit.org/attachment.cgi?id=355290&action=review

r=me

> Source/JavaScriptCore/ChangeLog:11
> +	   be return the empty JSValue in this case: instead, we should return
a Promise as

Wording, delete "be".