[webkit-reviews] review granted: [Bug 191822] Add SPI to disable JIT in a WKWebView : [Attachment 355287] Patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 191822: Add SPI to disable JIT in a WKWebView
https://bugs.webkit.org/show_bug.cgi?id=191822

Attachment 355287: Patch

https://bugs.webkit.org/attachment.cgi?id=355287&action=review




--- Comment #5 from Geoffrey Garen <ggaren at apple.com> ---
Comment on attachment 355287
  --> https://bugs.webkit.org/attachment.cgi?id=355287
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=355287&action=review

r=me

Still a few opportunities to increase naming consistency.

> Source/JavaScriptCore/jit/ExecutableAllocator.cpp:116
> +static bool s_jitEnabled = true;

s_isJITEnabled

> Source/JavaScriptCore/jit/ExecutableAllocator.cpp:128
> +void ExecutableAllocator::setJITEnabled(bool enabled)
> +{
> +    s_jitEnabled = enabled;

Probably worth an early return if the setting didn't change.

> Source/WebKit/UIProcess/WebProcessProxy.h:261
> +    bool JITEnabled() const final;

isJITEnabled()

> Source/WebKit/UIProcess/API/APIProcessPoolConfiguration.h:226
> +    bool m_JITEnabled { true };

m_isJITEnabled

> Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm:4773
> +    _page->isJITEnabled([completionHandler =
makeBlockPtr(completionHandler)] (bool canUse) {

canUse => isJITEnabled

> Source/WebKit/UIProcess/Launcher/ProcessLauncher.h:51
> +	   virtual bool JITEnabled() const { return true; }

isJITEnabled