[webkit-reviews] review granted: [Bug 190512] [WebAssembly] I64 arguments / return value check should be moved from callWebAssemblyFunction to JSToWasm wrapper : [Attachment 353600] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Nov 19 08:42:59 PST 2018
Keith Miller <keith_miller at apple.com> has granted Yusuke Suzuki
<yusukesuzuki at slowstart.org>'s request for review:
Bug 190512: [WebAssembly] I64 arguments / return value check should be moved
from callWebAssemblyFunction to JSToWasm wrapper
https://bugs.webkit.org/show_bug.cgi?id=190512
Attachment 353600: Patch
https://bugs.webkit.org/attachment.cgi?id=353600&action=review
--- Comment #14 from Keith Miller <keith_miller at apple.com> ---
Comment on attachment 353600
--> https://bugs.webkit.org/attachment.cgi?id=353600
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=353600&action=review
> Source/JavaScriptCore/wasm/js/WebAssemblyFunction.cpp:84
> + arg = JSValue::decode(0);
Nit I think you can just do:
arg = JSValue()
More information about the webkit-reviews
mailing list