[webkit-reviews] review granted: [Bug 191832] [GTK][WPE] Solve some issues in the enumerateDevices code : [Attachment 355263] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Nov 19 04:13:50 PST 2018
Carlos Garcia Campos <cgarcia at igalia.com> has granted Alejandro G. Castro
<alex at igalia.com>'s request for review:
Bug 191832: [GTK][WPE] Solve some issues in the enumerateDevices code
https://bugs.webkit.org/show_bug.cgi?id=191832
Attachment 355263: Patch
https://bugs.webkit.org/attachment.cgi?id=355263&action=review
--- Comment #3 from Carlos Garcia Campos <cgarcia at igalia.com> ---
Comment on attachment 355263
--> https://bugs.webkit.org/attachment.cgi?id=355263
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=355263&action=review
> Source/WebKit/UIProcess/API/gtk/WebKitWebsiteData.h:52
> - * Since: 2.16
> + * Since: 2.24
This was correct. You need to add the since tag after the new item added to the
enum.
> Source/WebKit/UIProcess/API/wpe/WebKitWebsiteData.h:52
> - * Since: 2.16
> + * Since: 2.24
Ditto.
More information about the webkit-reviews
mailing list