[webkit-reviews] review granted: [Bug 190932] Consider removing double load for accessing the instructions from LLInt : [Attachment 354567] Patch

[bugzilla-daemon at webkit.org]

Mark Lam <mark.lam at apple.com> has granted Yusuke Suzuki
<yusukesuzuki at slowstart.org>'s request for review:
Bug 190932: Consider removing double load for accessing the instructions from
LLInt
https://bugs.webkit.org/show_bug.cgi?id=190932

Attachment 354567: Patch

https://bugs.webkit.org/attachment.cgi?id=354567&action=review




--- Comment #7 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 354567
  --> https://bugs.webkit.org/attachment.cgi?id=354567
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=354567&action=review

r=me.

>>> Source/JavaScriptCore/llint/LowLevelInterpreter32_64.asm:1818
>>> +	 muli sizeof SimpleJumpTable, t3
>> 
>> What's the peephole opportunity the comment was talking about, and is it
invalid / inappropriate?  What is your reason for this change?
> 
> This removal is because we already did this optimization in
https://trac.webkit.org/changeset/237627/webkit.
> This comment means that we can perform strength reduction to convert `muli`
to `lshifti` if `sizeof SimpleJumpTable` is a power of two.

OK, thanks.